-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid blocking IO in downloader initialization #114841
Conversation
Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@MartinHjelmare, could this be the reason for #114829? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stacktrace is inconclusive. But this change is good.
Would you have any idea what could go wrong in the initialization that that stacktrace could be raised? Never seen that before |
No. That exception is raised when a future result/exception is set more than once or already canceled when set. |
* Avoid blocking IO in downloader initialization * Avoid blocking IO in downloader initialization
Proposed change
Avoid blocking IO in downloader initialization
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: